Add JavaScript SPA to ms-identity-docs code samples #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mples#50) * react-spa-code-update * remove-files
OwenRichards1
requested review from
Dickson-Mwendia,
cilwerner and
henrymbuguakiarie
Collaborator
Author
|
@cilwerner, @henrymbuguakiarie, @Dickson-Mwendia Can you review this PR - hoping to add a js-spa to our code samples, as we currently have differing samples in our doc set - thanks! |
cilwerner
approved these changes
Sep 18, 2023
Contributor
LGTM, will squash shortly, waiting until EOD Nairobi time in case @henrymbuguakiarie or @Dickson-Mwendia wish to add any comments |
Collaborator
Author
|
@cilwerner thanks for the approval - leave the merge to me as I have a few additional checks and updates to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
ms-identity-docs requires a JavaScript SPA to be used in quickstarts/tutorials - have taken sign-in app from ms-identity-javascript-tutorial, which is currently used in our doc set.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Ensure this samples is suitable for our samples.